• 2 Posts
  • 23 Comments
Joined 1 year ago
cake
Cake day: June 23rd, 2023

help-circle

  • Ew no.

    Abusing language features like this (boolean expression short circuit) just makes it harder for other people to come and maintain your code.

    The function does have opportunity for improvement by checking one thing at a time. This flattens the ifs and changes them into proper sentry clauses. It also opens the door to encapsulating their logic and refactoring this function into a proper validator that can return all the reasons a user is invalid.

    Good code is not “elegant” code. It’s code that is simple and unsurprising and can be easily understood by a hungover fresh graduate new hire.


  • None built in from what I recall. That was from back in 2011, so it’s possible things changed since.

    Reading through, it looks like retries do exist, but remember that duplicate packets are treated as a window reset, so it’s possible that transmission succeeded but the ack was lost.

    I remember the project demos from the course though - one team implemented some form of fast retry on two laptops and had one guy walk out and away. With regular wifi he didn’t even make it to the end of the hall before the video dropped out. With their custom stack he made it out of the building before it went.

    I’ll need to dig through to find the name of what they did.







  • I have either written or gotten a variant of every single one of these comments 🫠:

    Please include the JIRA task in the commit title.

    Did you run any manual testing?

    Where’s the PRD link in the commit message?

    Can you please split this into multiple smaller commits?

    Can you combine these two commits?

    Did you email Jon about this because he’s working on that project with Sarah and you might be duplicating efforts.

    This should be named BarFoo instead of FooBar.

    Why aren’t you using CorporateInternalLib16 that does 90% of this?

    Why aren’t you using ThirdPartyPaidLibByExEmployee?

    Why aren’t you using StandardLib thing you forgot existed?

    All our I/O should be async.

    All our hot loop code needs to be sync.

    This will increase latency of NonCoreBusinessFlow by 0.01%. can you shave some time off so we can push in feature B also?

    Please add a feature flag so we can do gradual rollout.

    What operational levers does this have?

    Lgtm - just address those comments